Skip to content

Commit

Permalink
Deprecate use_thin_archive (#2694)
Browse files Browse the repository at this point in the history
Thin archives are used on all platforms.

b/150410605
  • Loading branch information
kaidokert authored Mar 25, 2024
2 parents 03b5e92 + 1e9864a commit 94df067
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion cobalt/site/docs/reference/starboard/gn-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,5 @@ Book: /youtube/cobalt/_book.yaml
| **`starboard_level_final_executable_type`**<br><br>The default value is `"executable"`. |
| **`starboard_level_gtest_target_type`**<br><br>The default value is `"executable"`. |
| **`static_library_configs`**<br><br> Target-specific configurations for static_library targets.<br><br>The default value is `[]`. |
| **`use_thin_archive`**<br><br> Whether or not to link with thin archives.<br><br>The default value is `true`. |
| **`v8_enable_pointer_compression_override`**<br><br> Set to true to enable pointer compression for v8.<br><br>The default value is `true`. |
| **`v8_enable_webassembly`**<br><br> Enable WASM and install WebAssembly global.<br><br>The default value is `false`. |
5 changes: 1 addition & 4 deletions starboard/build/config/BUILDCONFIG.gn
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,9 @@ default_compiler_configs = [
"//starboard/build/config:warnings_as_errors",
"//starboard/build/config:default_compiler_flags",
"//starboard/build/config:default_cpp_standard",
"//build/config/compiler:thin_archive",
]

if (use_thin_archive) {
default_compiler_configs += [ "//build/config/compiler:thin_archive" ]
}

if (is_starboard) {
default_compiler_configs += [ "//starboard/build/config:starboard" ]
}
Expand Down
3 changes: 0 additions & 3 deletions starboard/build/config/base_configuration.gni
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,6 @@ declare_args() {
# Set to true to enable pointer compression for v8.
v8_enable_pointer_compression_override = true

# Whether or not to link with thin archives.
use_thin_archive = true

# Whether or not to disable run-time type information (adding no_rtti flag).
sb_use_no_rtti = false

Expand Down

0 comments on commit 94df067

Please sign in to comment.