Cherry pick PR #739: Fix memory leak where ref to JS callback was not…

… being deleted (#740) b/288915945 Change-Id: Ibc3f9d4e3a1457fbc4f57645d3073a521338f0d2 (cherry picked from commit 7b88f37) Co-authored-by: Joel Martinez <[email protected]>
youtube · Jun 27, 2023 · 9d2b68a · 9d2b68a
1 parent 9ffe76a
commit 9d2b68a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cobalt/h5vcc/h5vcc_metrics.h b/cobalt/h5vcc/h5vcc_metrics.h
@@ -77,7 +77,7 @@ class H5vccMetrics : public script::Wrappable {
       const cobalt::h5vcc::H5vccMetricType& metric_type,
       const std::string& serialized_proto);
 
-  h5vcc::MetricEventHandlerWrapper* uploader_callback_ = nullptr;
+  scoped_refptr<h5vcc::MetricEventHandlerWrapper> uploader_callback_;
 
   std::unique_ptr<cobalt::browser::metrics::CobaltMetricsUploaderCallback>
       run_event_handler_callback_;