Deprecate VIRTUAL_REALITY from Starboard

b/150410605
youtube · Mar 27, 2024 · bd3c6c5 · bd3c6c5
1 parent 92151b6
commit bd3c6c5
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 28 deletions.
diff --git a/cobalt/layout/replaced_box.cc b/cobalt/layout/replaced_box.cc
@@ -739,21 +739,12 @@ void ReplacedBox::RenderAndAnimateContentWithMapToMesh(
   filter_node =
       new FilterNode(MapToMeshFilter(stereo_mode, builder), animate_node);
 
-#if !SB_HAS(VIRTUAL_REALITY)
   // Attach a 3D camera to the map-to-mesh node, so the rendering of its
   // content can be transformed.
   border_node_builder->AddChild(
       used_style_provider()->attach_camera_node_function().Run(
           filter_node, mtm_function->horizontal_fov_in_radians(),
           mtm_function->vertical_fov_in_radians()));
-#else
-  // Camera node unnecessary in VR, since the 3D scene is completely
-  // immersive, and the whole render tree is placed within it and subject to
-  // camera transforms, not just the map-to-mesh node.
-  // TODO: Reconcile both paths with respect to this if Cobalt adopts a global
-  // camera or a document-wide notion of 3D space layout.
-  border_node_builder->AddChild(filter_node);
-#endif
 }
 
 void ReplacedBox::RenderAndAnimateContentWithLetterboxing(

diff --git a/cobalt/site/docs/reference/starboard/configuration-public.md b/cobalt/site/docs/reference/starboard/configuration-public.md
@@ -30,13 +30,6 @@ Book: /youtube/cobalt/_book.yaml
 | **`SB_HAS_QUIRK_HASH_FILE_NAME`**<br><br>On some platforms the file system cannot access extremely long file names. We do not need this feature on stub.<br><br>By default, this property is undefined. |
 
 
-## Graphics Configuration
-
-| Properties |
-| :--- |
-| **`SB_HAS_VIRTUAL_REALITY`**<br><br>The default value in the Stub implementation is `1` |
-
-
 ## I/O Configuration
 
 | Properties |

diff --git a/starboard/CHANGELOG.md b/starboard/CHANGELOG.md
@@ -9,6 +9,9 @@ since the version previous to it.
 
 ## Version 16
 
+## Removed `VIRTUAL_REALITY` configuration
+This configuration is unused by Cobalt.
+
 ### Removed configuration for `abort_on_allocation_failure`
 This flag has no effect in builds, and checked allocations are removed
 in Starboard 16.

diff --git a/starboard/stub/configuration_public.h b/starboard/stub/configuration_public.h
@@ -102,10 +102,6 @@
 // We do not need this feature on stub.
 #undef SB_HAS_QUIRK_HASH_FILE_NAME
 
-// --- Graphics Configuration ------------------------------------------------
-
-#define SB_HAS_VIRTUAL_REALITY 1
-
 // --- I/O Configuration -----------------------------------------------------
 
 // Whether the current platform implements the on screen keyboard interface.

diff --git a/starboard/win/shared/configuration_public.h b/starboard/win/shared/configuration_public.h
@@ -73,10 +73,6 @@
 // the current linking unit.
 #define SB_IMPORT_PLATFORM
 
-// --- Graphics Configuration ------------------------------------------------
-
-#define SB_HAS_VIRTUAL_REALITY 0
-
 // --- I/O Configuration -----------------------------------------------------
 
 // Whether the current platform supports on screen keyboard.

diff --git a/starboard/xb1/shared/configuration_public.h b/starboard/xb1/shared/configuration_public.h
@@ -72,10 +72,6 @@
 // the current linking unit.
 #define SB_IMPORT_PLATFORM __declspec(dllimport)
 
-// --- Graphics Configuration ------------------------------------------------
-
-#define SB_HAS_VIRTUAL_REALITY 0
-
 // --- I/O Configuration -----------------------------------------------------
 
 // Whether the current platform has speech synthesis.