Skip to content

Commit

Permalink
Remove SB_API_VERSION < 17 checks for starboard/stub
Browse files Browse the repository at this point in the history
Change-Id: Ic61c423774b569ea78db2fdecafdda0275064a14
  • Loading branch information
madhurajayaraman committed Sep 11, 2024
1 parent 5fb33e3 commit c76291a
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 19 deletions.
2 changes: 0 additions & 2 deletions starboard/android/shared/android_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,6 @@ Java_dev_cobalt_coat_VolumeStateReceiver_nativeMuteChanged(JNIEnv* env,

} // namespace

#if SB_API_VERSION >= 15
extern "C" int SbRunStarboardMain(int argc,
char** argv,
SbEventHandleCallback callback) {
Expand Down Expand Up @@ -419,7 +418,6 @@ extern "C" int SbRunStarboardMain(int argc,

return error_level;
}
#endif // SB_API_VERSION >= 15

} // namespace shared
} // namespace android
Expand Down
4 changes: 0 additions & 4 deletions starboard/stub/application_stub.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,8 @@
namespace starboard {
namespace stub {

#if SB_API_VERSION >= 15
ApplicationStub::ApplicationStub(SbEventHandleCallback sb_event_handle_callback)
: QueueApplication(sb_event_handle_callback) {}
#else
ApplicationStub::ApplicationStub() {}
#endif // SB_API_VERSION >= 15

ApplicationStub::~ApplicationStub() {}

Expand Down
4 changes: 0 additions & 4 deletions starboard/stub/application_stub.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@ namespace stub {
// Stub application engine using the generic queue and a stub implementation.
class ApplicationStub : public shared::starboard::QueueApplication {
public:
#if SB_API_VERSION >= 15
explicit ApplicationStub(SbEventHandleCallback sb_event_handle_callback);
#else
ApplicationStub();
#endif // SB_API_VERSION >= 15

~ApplicationStub() override;

Expand Down
2 changes: 0 additions & 2 deletions starboard/stub/configuration_constants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,9 @@ const int kSbPreferredRgbaByteOrder = SB_PREFERRED_RGBA_BYTE_ORDER_RGBA;
// The maximum size the cache directory is allowed to use in bytes.
const uint32_t kSbMaxSystemPathCacheDirectorySize = 24 << 20; // 24MiB

#if SB_API_VERSION >= 16
// Whether this platform can map executable memory. This is required for
// platforms that want to JIT.
SB_EXPORT extern const bool kSbCanMapExecutableMemory = false;

// Platform can support partial audio frames
SB_EXPORT extern const bool kHasPartialAudioFramesSupport = false;
#endif
7 changes: 0 additions & 7 deletions starboard/stub/main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,10 @@
#include "starboard/stub/application_stub.h"

int main(int argc, char** argv) {
#if SB_API_VERSION >= 15
return SbRunStarboardMain(argc, argv, SbEventHandle);
#else
starboard::stub::ApplicationStub application;
return application.Run(argc, argv);
#endif // SB_API_VERSION >= 15
}

#if SB_API_VERSION >= 15
int SbRunStarboardMain(int argc, char** argv, SbEventHandleCallback callback) {
starboard::stub::ApplicationStub application(callback);
return application.Run(argc, argv);
}
#endif // SB_API_VERSION >= 15

0 comments on commit c76291a

Please sign in to comment.