Skip to content

Commit

Permalink
Remove starboard:gn_all dep on crashpad/handler (#1125)
Browse files Browse the repository at this point in the history
After Cobalt 23 we want the crashpad_handler binary to always be built
with the native target toolchain, and never with Starboard. With this
PR, the ninja files for the Starboard-based target will no longer be
generated.

b/270858365

Change-Id: I3d206468bbf2385a79506c164b68b6ee98d97982
  • Loading branch information
hlwarriner committed Aug 7, 2023
1 parent d1714cd commit cae93f9
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions starboard/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,7 @@ group("gn_all") {
deps += [ "//third_party/lz4_lib:lz4" ]

if (sb_is_evergreen_compatible) {
deps += [
"//third_party/crashpad/client",

# TODO(b/270858365): remove this dependency on the Starboard-based
# target (from the target toolchain) once Buildbot is using the native
# target (from native_target toolchain) and no longer declares the
# Starboard-based one as a build target.
"//third_party/crashpad/handler",
]
deps += [ "//third_party/crashpad/client" ]
data_deps = [
"//starboard/loader_app",
"//third_party/crashpad/handler:crashpad_handler(//$starboard_path/toolchain:native_target)",
Expand Down

0 comments on commit cae93f9

Please sign in to comment.