Disable Cast codec tests by default (#4073)

Those codecs are not required by Technical Requirements, disabling by default. Making it configurable can be done as follow-up. b/362356408
youtube · Aug 30, 2024 · cb6d796 · cb6d796
1 parent f3c7f6d
commit cb6d796
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/starboard/linux/shared/platform_configuration/configuration.gni b/starboard/linux/shared/platform_configuration/configuration.gni
@@ -41,3 +41,5 @@ platform_tests_path =
 enable_in_app_dial = true
 
 v8_enable_webassembly = true
+
+sb_enable_cast_codec_tests = true
diff --git a/starboard/nplb/BUILD.gn b/starboard/nplb/BUILD.gn
@@ -14,6 +14,14 @@
 
 import("//starboard/build/config/os_definitions.gni")
 
+declare_args() {
+  sb_enable_cast_codec_tests = false
+}
+
+config("cast_codec_tests") {
+  cflags = [ "ENABLE_CAST_CODEC_TESTS" ]
+}
+
 target(gtest_target_type, "nplb") {
   testonly = true
 
@@ -302,6 +310,9 @@ target(gtest_target_type, "nplb") {
   ]
 
   configs += [ "//starboard/build/config:starboard_implementation" ]
+  if (sb_enable_cast_codec_tests) {
+    configs += [ ":cast_codec_tests" ]
+  }
 
   deps = [
     "//starboard:starboard_group",

diff --git a/starboard/nplb/player_test_util.cc b/starboard/nplb/player_test_util.cc
@@ -60,18 +60,22 @@ const char* kAudioOnlyTestFiles[] = {
     "iamf_base_profile_stereo_ambisonics.dmp",
     "iamf_simple_profile_5_1.dmp",
 #endif  // SB_API_VERSION >= 15
+    "sintel_5s_pcm_s16le.dmp",
     "sintel_5s_flac.dmp",
+#if defined(ENABLE_CAST_CODEC_TESTS)
     "sintel_5s_mp3.dmp",
-    "sintel_5s_pcm_s16le.dmp",
     "sintel_5s_vorbis.dmp",
+#endif
 };
 
 const char* kVideoTestFiles[] = {
     "beneath_the_canopy_137_avc.dmp",
     "beneath_the_canopy_248_vp9.dmp",
     "sintel_399_av1.dmp",
+#if defined(ENABLE_CAST_CODEC_TESTS)
     "sintel_5s_vp8.dmp",
     "sintel_5s_hevc.dmp",
+#endif
 };
 
 const SbPlayerOutputMode kOutputModes[] = {kSbPlayerOutputModeDecodeToTexture,