Cherry pick PR #711: Fix issue where only one metrics upload was occu…

…rring (#750)

Turns out, the metrics libraries need to be regularly told the app has
not gone idle between metrics uploads.

Added a timer to the demo and a note about the initial upload interval
as well.

b/288915935

Change-Id: I93b322615467344e6db48883950cae644b1e551d
(cherry picked from commit cb1e721)

Co-authored-by: Joel Martinez <[email protected]>

cobalt/browser/metrics/cobalt_metrics_service_client.cc

@@ -125,6 +125,13 @@ void CobaltMetricsServiceClient::CollectFinalMetricsForLog(
   // Chrome uses this to update memory histograms. Regardless, you must call
   // done_callback when done else the uploader will never get invoked.
   std::move(done_callback).Run();
+
+  // MetricsService will shut itself down if the app doesn't periodically tell
+  // it it's not idle. In Cobalt's case, we don't want this behavior. Watch
+  // sessions for LR can happen for extended periods of time with no action by
+  // the user. So, we always just set the app as "non-idle" immediately after
+  // each metric log is finalized.
+  GetMetricsService()->OnApplicationNotIdle();
 }
 
 std::string CobaltMetricsServiceClient::GetMetricsServerUrl() {

cobalt/demos/content/telemetry/index.html

@@ -37,13 +37,20 @@ <h1>LOG OUTPUT:</h1>
         }
 
         function init() {
-            log('Initializing window.h5vcc.metrics');
+            log('Initializing window.h5vcc.metrics.');
+            let timer = 0;
+            let interval = 10000;
+            setInterval(() => {
+                timer += interval;
+                log(`timer: ${timer / 1000}s`);
+            }, interval);
 
             const metrics = window.h5vcc.metrics;
             log(`Getting metrics enabled state metrics.isEnabled(): ${metrics.isEnabled()}`);
             log('Enabling metrics reporting: metrics.enable()');
             metrics.enable();
             log(`Setting metric event interval: metrics.setMetricEventInterval(${EVENT_INTERVAL_SECS})`);
+            log(`Note that the first upload interval will always be 60 seconds, regardless of metricEventInterval.`);
             metrics.setMetricEventInterval(EVENT_INTERVAL_SECS);
             log('Binding metric event handler: metrics.onMetricEvent(metricEventHandler)');
             metrics.onMetricEvent(metricEventHandler);