Skip to content

Commit

Permalink
Cherry pick PR #3564: [android] Disable failing WriteSingleBatch tests (
Browse files Browse the repository at this point in the history
#3567)

Refer to the original PR: #3564

This PR (#3325) changes
SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt
supports multiple samples per write to SbPlayer (b/227837774), but
current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests
are not long enough for the modification. Disable the tests and should
be re-enabled once it fixes.

b/347097484

Co-authored-by: Bo-Rong Chen <[email protected]>
  • Loading branch information
cobalt-github-releaser-bot and borongc authored Jun 14, 2024
1 parent 19e1d96 commit f4c696c
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions starboard/android/shared/test_filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@

# TODO: b/280432564 Make this test work on lab devices consistently.
'SbAudioSinkTest.ContinuousAppend',

## TODO: b/347097484 This test failed/crashed with SbPlayerGetMaximumNumberOfSamplesPerWrite() of 256.
'SbPlayerWriteSampleTests/SbPlayerWriteSampleTest.WriteSingleBatch/*',
],
}
# pylint: enable=line-too-long
Expand Down

0 comments on commit f4c696c

Please sign in to comment.