Re-enables cert-related tests by disabling individual cases

b/331472624 Change-Id: Ief67f72123846ff91681db163b6fab85c2043d8b
youtube · Mar 27, 2024 · f878117 · f878117
1 parent c21ab66
commit f878117
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/net/BUILD.gn b/net/BUILD.gn
@@ -3341,10 +3341,6 @@ test("net_unittests") {
       # TODO: b/331469815
       "socket/tcp_client_socket_unittest.cc",
 
-      # TODO: b/331472624
-      "cert/pki/path_builder_unittest.cc",
-      "cert/multi_threaded_cert_verifier_unittest.cc",
-
       # Re-enable once we're on c++20
       "base/backoff_entry_serializer_unittest.cc",
     ]

diff --git a/net/cert/multi_threaded_cert_verifier_unittest.cc b/net/cert/multi_threaded_cert_verifier_unittest.cc
@@ -249,6 +249,8 @@ TEST_F(MultiThreadedCertVerifierTest, CancelRequestThenQuit) {
   // Destroy |verifier_| by going out of scope.
 }
 
+// Starboard disables cert_net_fetcher which results in different error cause.
+#if !defined(STARBOARD)
 // Tests propagation of configuration options into CertVerifyProc flags
 TEST_F(MultiThreadedCertVerifierTest, ConvertsConfigToFlags) {
   base::FilePath certs_dir = GetTestCertsDirectory();
@@ -297,6 +299,7 @@ TEST_F(MultiThreadedCertVerifierTest, ConvertsConfigToFlags) {
     testing::Mock::VerifyAndClearExpectations(mock_verify_proc_.get());
   }
 }
+#endif
 
 // Tests propagation of CertVerifier flags into CertVerifyProc flags
 TEST_F(MultiThreadedCertVerifierTest, ConvertsFlagsToFlags) {