[Win] Move references to the XDK to internal

[TyHolc]

Make references to the XDK internal-only to allow the external version to build properly.

b/296290769

Change-Id: I3bf4c59de1fd3163028d713586294a2a93f403be

[codecov]

Codecov Report

Merging #1342 (6b851e9) into main (3483cb4) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 6b851e9 differs from pull request most recent head 91b0c0f. Consider uploading reports for the commit 91b0c0f to get more accurate results

@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
- Coverage   57.78%   57.59%   -0.19%     
==========================================
  Files        1915     1905      -10     
  Lines       95108    94759     -349     
==========================================
- Hits        54954    54575     -379     
- Misses      40154    40184      +30     

see 59 files with indirect coverage changes

[isarkis]

@TyHolc, is this PR ready to be tested on XB1 runners in cobalt_sandbox?

[andrewsavage1]

Is this ready to be submitted or do we have more testing to do for it?

[TyHolc]

Is this ready to be submitted or do we have more testing to do for it?

This should be ready, the try-builds passed (though xb1 tests have been failing for other reasons). Since it's kind of stale I'll rebase and rerun try-builds.

[andrewsavage1]

This should be ready, the try-builds passed (though xb1 tests have been failing for other reasons). Since it's kind of stale I'll rebase and rerun try-builds.

Does it work on github?

[TyHolc]

Does it work on github?

@isarkis have you been able to rebase on top of this and try to build it via github?

[TyHolc]

@TyHolc, is this PR ready to be tested on XB1 runners in cobalt_sandbox?

Sorry I missed this, that was the first day I was sick. Yes, we can try this on the cobalt sandbox runners. Let me know if there's more that needs to be done.

[isarkis]

@TyHolc, is this PR ready to be tested on XB1 runners in cobalt_sandbox?

Sorry I missed this, that was the first day I was sick. Yes, we can try this on the cobalt sandbox runners. Let me know if there's more that needs to be done.

Getting an error, see https://github.com/youtube/cobalt_sandbox/actions/runs/6240395072/job/16940433339

Can you take a look at youtube/cobalt_sandbox#513, do the Dockerfiles look correct?

[andrewsavage1]

@TyHolc could you please try to build xb1 in docker locally?

[TyHolc]

@TyHolc, is this PR ready to be tested on XB1 runners in cobalt_sandbox?

Sorry I missed this, that was the first day I was sick. Yes, we can try this on the cobalt sandbox runners. Let me know if there's more that needs to be done.

Getting an error, see youtube/cobalt_sandbox/actions/runs/6240395072/job/16940433339

Can you take a look at youtube/cobalt_sandbox#513, do the Dockerfiles look correct?

The Dockerfiles look correct. I verified the Win SDK link and win SDK version are correct.

As for that error, the missing classes should exist in the Win SDK and not the XDK, but maybe we have to pull in additional dependencies to cover ones lost by removing the XDK. Locally this build worked for me without needing to include anything additional (and while renaming all XDK folders in case the build was picking them up). I wasn't able to verify with Docker due to issues with my Windows machine though. I'll see if I can get that working again.