Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert checkout action to upstream #2169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kaidokert
Copy link
Member

@kaidokert kaidokert commented Jan 6, 2024

Upstream still hasn't patched the issue, but our builds seem to not trip on submodules at the moment.

b/282361986

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.56%. Comparing base (e91418d) to head (7cdcc6b).
Report is 1 commits behind head on main.

Current head 7cdcc6b differs from pull request most recent head 59e4ff9

Please upload reports for the commit 59e4ff9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
+ Coverage   57.99%   58.56%   +0.56%     
==========================================
  Files        1778     1909     +131     
  Lines       84836    94579    +9743     
==========================================
+ Hits        49204    55389    +6185     
- Misses      35632    39190    +3558     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaidokert kaidokert marked this pull request as draft January 6, 2024 18:14
@kaidokert kaidokert marked this pull request as ready for review May 24, 2024 21:40
@kaidokert kaidokert requested review from isarkis and oxve May 24, 2024 21:40
@kaidokert
Copy link
Member Author

This is blocked on node20 not running on our old Ubuntu. Will need a solution for that or Ubuntu containers update #3327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant