Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ABI wrappers to not rely on --wrap #2665

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

gbournou
Copy link
Contributor

@gbournou gbournou commented Mar 21, 2024

b/330648201

Test-On-Device: true

@gbournou gbournou force-pushed the wrapping branch 2 times, most recently from 2071018 to cd305e2 Compare March 21, 2024 05:35
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 58.86%. Comparing base (60884cb) to head (fd69425).
Report is 10 commits behind head on main.

Files Patch % Lines
...ular/starboard_layer_posix_pthread_abi_wrappers.cc 0.00% 15 Missing ⚠️
...modular/starboard_layer_posix_time_abi_wrappers.cc 0.00% 4 Missing ⚠️
.../modular/starboard_layer_posix_time_abi_wrappers.h 0.00% 4 Missing ⚠️
...modular/starboard_layer_posix_mmap_abi_wrappers.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
- Coverage   58.87%   58.86%   -0.02%     
==========================================
  Files        1908     1908              
  Lines       94447    94449       +2     
==========================================
- Hits        55604    55595       -9     
- Misses      38843    38854      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsavage1
Copy link
Contributor

Is there a good way for us to ensure that this would not conflict with wrapping at the starboard layer in some way? I.e. some commit on top of this that we won't submit that tests wrapping a symbol at the starboard layer?

@gbournou
Copy link
Contributor Author

Is there a good way for us to ensure that this would not conflict with wrapping at the starboard layer in some way? I.e. some commit on top of this that we won't submit that tests wrapping a symbol at the starboard layer?

My plan was to follow up with a PR to convert the existing macro-based cases to use --wrap. Not sure what other kind of commit you were thinking of

@gbournou
Copy link
Contributor Author

The single Raspi failure is from an unrelated issue and should be fixed in #2719

@gbournou gbournou merged commit 12f1046 into youtube:main Mar 26, 2024
380 of 383 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants