-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ABI wrappers to not rely on --wrap #2665
Conversation
2071018
to
cd305e2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2665 +/- ##
==========================================
- Coverage 58.87% 58.86% -0.02%
==========================================
Files 1908 1908
Lines 94447 94449 +2
==========================================
- Hits 55604 55595 -9
- Misses 38843 38854 +11 ☔ View full report in Codecov by Sentry. |
Is there a good way for us to ensure that this would not conflict with wrapping at the starboard layer in some way? I.e. some commit on top of this that we won't submit that tests wrapping a symbol at the starboard layer? |
My plan was to follow up with a PR to convert the existing macro-based cases to use --wrap. Not sure what other kind of commit you were thinking of |
starboard/shared/modular/cobalt_layer_posix_time_abi_wrappers.cc
Outdated
Show resolved
Hide resolved
b/330648201
The single Raspi failure is from an unrelated issue and should be fixed in #2719 |
b/330648201
Test-On-Device: true