Add Cobalt Telemetry for the Loader App #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A LoaderAppMetrics Starboard extension is added so that measurements taken by the Loader App can be reliably accessed by Cobalt once loaded. This PR just adds one metric for now, for b/329458881, but this pattern and extension can be used for b/329445690 and other Loader App metrics. b/329458881 Change-Id: I940d07b058d197afa2ad8b1160eba469f1055f8a
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2667 +/- ##
==========================================
- Coverage 58.25% 58.25% -0.01%
==========================================
Files 1794 1798 +4
Lines 84889 84936 +47
==========================================
+ Hits 49450 49477 +27
- Misses 35439 35459 +20 ☔ View full report in Codecov by Sentry. |
|
Cc @yuying-y |
joeltine
approved these changes
Mar 21, 2024
y4vor
reviewed
Mar 25, 2024
Change-Id: Ie689f7b020f624c21e42d16ec59cb535440638c7
y4vor
approved these changes
Mar 25, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
A LoaderAppMetrics Starboard extension is added so that measurements taken by the Loader App can be reliably accessed by Cobalt once loaded. This PR just adds one metric for now, for b/329458881, but this pattern and extension can be used for b/329445690 and other Loader App metrics. b/329458881 Change-Id: I940d07b058d197afa2ad8b1160eba469f1055f8a (cherry picked from commit bf93736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A LoaderAppMetrics Starboard extension is added so that measurements taken by the Loader App can be reliably accessed by Cobalt once loaded. This PR just adds one metric for now, for b/329458881, but this pattern and extension can be used for b/329445690 and other Loader App metrics.
b/329458881
Change-Id: I940d07b058d197afa2ad8b1160eba469f1055f8a