Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick PR #2608: [media] Remove capability change media error #2677

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Cherry pick PR #2608: [media] Remove capability change media error #2677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49aafc6
[media] Deprecate capability change media error (#2608)
osagie98 Mar 20, 2024
3aaccae
Merge branch '24.lts.1+' into cherry-pick-24.lts.1+-2608
osagie98 Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cobalt/dom/media_error.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ interface MediaError {
const unsigned short MEDIA_ERR_DECODE = 3;
const unsigned short MEDIA_ERR_SRC_NOT_SUPPORTED = 4;
const unsigned short MEDIA_ERR_ENCRYPTED = 5;
// The underlying playback capability has changed, the app should treat this
// as a transient error and retry playback.
// Deprecated. Capability change errors are reported with
// code MEDIA_ERR_DECODE.
const unsigned short MEDIA_ERR_CAPABILITY_CHANGED = 1000;

readonly attribute unsigned short code;
Expand Down
4 changes: 3 additions & 1 deletion tools/metrics/histograms/metadata/cobalt/enums.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histogra
<int value="21" label="PIPELINE_ERROR_EXTERNAL_RENDERER_FAILED"/>
<int value="22" label="DEMUXER_ERROR_DETECTED_HLS"/>
<int value="23" label="PIPELINE_ERROR_HARDWARE_CONTEXT_RESET"/>
<int value="24" label="PLAYBACK_CAPABILITY_CHANGED"/>
<!-- Deprecated. Capability change errors are reported with
PIPELINE_ERROR_DECODE -->
<int value="24" label="PLAYBACK_CAPABILITY_CHANGED (deprecated)"/>
</enum>


Expand Down
Loading