Don't raise error in HTMLMediaElement.h5vccAudioConnectors #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 29880 Passed, 1 Skipped, 10m 21.81s Wall Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2687 +/- ##
==========================================
+ Coverage 58.24% 58.88% +0.64%
==========================================
Files 1794 1811 +17
Lines 84889 87501 +2612
==========================================
+ Hits 49443 51526 +2083
- Misses 35446 35975 +529 ☔ View full report in Codecov by Sentry. |
xiaomings
reviewed
Mar 24, 2024
zhongqiliang
force-pushed
the
b-330929788_HTMLMediaElement_idl
branch
from
bf17afe
to
544efc5
Compare
zhongqiliang
changed the title
xiaomings
approved these changes
Mar 25, 2024
zhongqiliang
added
cp-23.lts.1+
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
b/330929788 Co-authored-by: Colin Liang <[email protected]> (cherry picked from commit cb7bc13)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
b/330929788 Co-authored-by: Colin Liang <[email protected]> (cherry picked from commit cb7bc13)
zhongqiliang
added a commit
that referenced
this pull request
Mar 26, 2024
b/330929788 Co-authored-by: Colin Liang <[email protected]> (cherry picked from commit cb7bc13)
zhongqiliang
added a commit
that referenced
this pull request
Apr 6, 2024
b/330929788 Co-authored-by: Colin Liang <[email protected]> (cherry picked from commit cb7bc13)
zhongqiliang
added a commit
that referenced
this pull request
Apr 6, 2024
…oConnectors (#2715) Refer to the original PR: #2687 b/330929788 Co-authored-by: Colin Liang <[email protected]>
zhongqiliang
added a commit
that referenced
this pull request
Apr 8, 2024
…oConnectors (#2714) Refer to the original PR: #2687 b/330929788 Co-authored-by: Colin Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/330929788