Add C++20 audit #2688
Merged
Add C++20 audit #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
force-pushed
the
cpp-20-check
branch
from
1068c35
to
1caff7d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
==========================================
+ Coverage 58.87% 58.89% +0.01%
==========================================
Files 1908 1908
Lines 94447 94447
==========================================
+ Hits 55604 55622 +18
+ Misses 38843 38825 -18 ☔ View full report in Codecov by Sentry. |
niranjanyardi
force-pushed
the
cpp-20-check
branch
from
1caff7d
to
66fc344
Compare
kaidokert
reviewed
Mar 25, 2024
kaidokert
reviewed
Mar 25, 2024
kaidokert
reviewed
Mar 25, 2024
y4vor
reviewed
Mar 25, 2024
niranjanyardi
force-pushed
the
cpp-20-check
branch
from
66fc344
to
574e26a
Compare
kaidokert
reviewed
Mar 25, 2024
kaidokert
approved these changes
Mar 25, 2024
niranjanyardi
force-pushed
the
cpp-20-check
branch
2 times, most recently
from
07292ef
to
27dad7e
Compare
Closed
niranjanyardi
force-pushed
the
cpp-20-check
branch
4 times, most recently
from
4284057
to
e138be0
Compare
b/309847996 Change-Id: Ib691cdcdf017bf2b902e2d795a2b29fdf4f1db8c
b/309847996 Change-Id: If8d17e5182f06577db9293be4defd8120aa77085
b/309847996 Change-Id: I3b9f16199bca34385d7e31adf2f541b3cf73bc83
b/309847996 Change-Id: I3263c57ac7c5fa9a84f4f6277e405cb2061993ad
b/309847996 Change-Id: I0c220570d67e692c00a52a9034fc935c2c204318
b/309847996 Change-Id: I538fa194d1a76c447ae328e320dd3f1d6c24613b
Change-Id: Idb7387e56036fb4b7cbda406b14f91b7e11759c6
Change-Id: I898f97286bc15229b8c8ce0f9670614ff0d4d274
Refactor linux, stub platform config flags into 'default_cpp_standard'. Only apply `default_cpp_standard` to default toolchain, avoid applying it to other toolchains like host_toolchain. Change-Id: Ia533601ceb7a0bd8f906dbb5ba885191ea4adb04
Change-Id: I0944883eca106cc48de8f77474be9efbb0303c77
niranjanyardi
force-pushed
the
cpp-20-check
branch
from
4178f71
to
04b9e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/309847996
b/329683364
Refactor c++17 flags from all platforms used while building cobalt into a central place "default_cpp_standard" in starboard/build/config/BUILD.gn
Remove default config while compiling c++20 audit, add "cpp20_supported_config" in it's place.
Co-author: andrewsavage1