Add Starboard thread_sampler APIs to Android #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ifb64271ced9df64cce67ad3e545fe8a59fe813c1
aelzeiny
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2689 +/- ##
==========================================
+ Coverage 58.27% 58.90% +0.63%
==========================================
Files 1795 1812 +17
Lines 84862 87479 +2617
==========================================
+ Hits 49450 51533 +2083
- Misses 35412 35946 +534 ☔ View full report in Codecov by Sentry. |
zhongqiliang
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
LGTM.
The orignal implementation is https://lbshell-internal-review.git.corp.google.com/c/starboard/+/123104
|
Please wait for x86 on device tests to be verified. |
|
Merging |
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Swaps Starboard's thread_sampler APIs for Android TV from stub to shared implementations (`//starboard/shared/stub/thread_sampler_*` to `//starboard/shared/pthread/thread_sampler_*`). Tested on Android TV (x64), Google TV Emulator (arm64), and a real Google TV device (arm). Test-On-Device: true b/330564529 Co-authored-by: Ahmed Elzeiny <[email protected]> (cherry picked from commit 7984c7a)
aelzeiny
added a commit
that referenced
this pull request
Mar 27, 2024
…2721) Refer to the original PR: #2689 Swaps Starboard's thread_sampler APIs for Android TV from stub to shared implementations (`//starboard/shared/stub/thread_sampler_*` to `//starboard/shared/pthread/thread_sampler_*`). Tested on Android TV (x64), Google TV Emulator (arm64), and a real Google TV device (arm). Test-On-Device: true b/330564529 Co-authored-by: Ahmed Elzeiny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps Starboard's thread_sampler APIs for Android TV from stub to shared implementations (
//starboard/shared/stub/thread_sampler_*to//starboard/shared/pthread/thread_sampler_*).Tested on Android TV (x64), Google TV Emulator (arm64), and a real Google TV device (arm).
Test-On-Device: true
b/330564529