Add SbWindowGetDisplayHandle to Starboard Windowing interface #2690
+138
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
force-pushed
the
displaywindowhandle
branch
2 times, most recently
from
f941c5d
to
ab039df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
==========================================
- Coverage 58.25% 58.18% -0.07%
==========================================
Files 1794 1896 +102
Lines 84889 94012 +9123
==========================================
+ Hits 49450 54703 +5253
- Misses 35439 39309 +3870 ☔ View full report in Codecov by Sentry. |
Adding a function to retrieves native EGL display handle, which will
simplifying correct EGL context initialization on Windowing systems
like GBM or Wayland.
This complements already existing SbWindowGetPlatformHandle.
Our current EGL initialization sequence calls:
eglGetDisplay(SB_EGL_DEFAULT_DISPLAY)
However, some windowing setups require native display
handle to be passed in, instead of passing the default.
b/157237252
b/157237252
kaidokert
force-pushed
the
displaywindowhandle
branch
from
ab039df
to
d4650d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a function to retrieves native EGL display handle, which will simplifying correct EGL context initialization on Windowing systems like GBM or Wayland.
This complements already existing SbWindowGetPlatformHandle.
Our current EGL initialization sequence calls:
However, some windowing setups require native display handle to be passed in, instead of passing the default.
b/157237252