Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate abort_on_alloc_failure #2693

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Deprecate abort_on_alloc_failure #2693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cobalt/site/docs/reference/starboard/gn-configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Book: /youtube/cobalt/_book.yaml

| Variables |
| :--- |
| **`abort_on_allocation_failure`**<br><br> Halt execution on failure to allocate memory.<br><br>The default value is `true`. |
hlwarriner marked this conversation as resolved.
Show resolved Hide resolved
| **`asan_symbolizer_path`**<br><br> A symbolizer path for ASAN can be added to allow translation of callstacks.<br><br>The default value is `"<clang_base_path>/bin/llvm-symbolizer"`. |
| **`cobalt_licenses_platform`**<br><br> Sub-directory to copy license file to.<br><br>The default value is `"default"`. |
| **`cobalt_platform_dependencies`**<br><br> List of platform-specific targets that get compiled into cobalt.<br><br>The default value is `[]`. |
Expand Down
4 changes: 4 additions & 0 deletions starboard/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ since the version previous to it.

## Version 16

### Removed configuration for `abort_on_allocation_failure`
This flag has no effect in builds, and checked allocations are removed
in Starboard 16.

### Removed SB_HAS_NV12_TEXTURE_SUPPORT
This flag is resolved at run-time.

Expand Down
4 changes: 0 additions & 4 deletions starboard/build/config/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ config("starboard") {
]
}

if (abort_on_allocation_failure) {
defines += [ "SB_ABORT_ON_ALLOCATION_FAILURE" ]
}

if (is_internal_build) {
defines += [ "INTERNAL_BUILD" ]
}
Expand Down
3 changes: 0 additions & 3 deletions starboard/build/config/base_configuration.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ declare_args() {
starboard_level_gtest_target_type = "executable"
starboard_level_final_executable_type = "executable"

# Halt execution on failure to allocate memory.
abort_on_allocation_failure = true

# The source of EGL and GLES headers and libraries.
# Valid values (case and everything sensitive!):
# "system_gles2" - Use the system implementation of EGL + GLES2. The
Expand Down
Loading