[media] Fix non-guarded customizations in //third_party/chromium/media #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
==========================================
- Coverage 58.85% 58.84% -0.02%
==========================================
Files 1904 1904
Lines 93311 93311
==========================================
- Hits 54920 54907 -13
- Misses 38391 38404 +13 ☔ View full report in Codecov by Sentry. |
borongc
force-pushed
the
chromium_media_guarded
branch
2 times, most recently
from
3e37e3a
to
c2e433c
Compare
borongc
force-pushed
the
chromium_media_guarded
branch
2 times, most recently
from
eafedd1
to
93175eb
Compare
All modification to Chromium media code is guarded by `#if defined(STARBOARD)`. b/329702113
borongc
force-pushed
the
chromium_media_guarded
branch
from
93175eb
to
d7a7ed5
Compare
osagie98
approved these changes
Mar 26, 2024
borongc
added a commit
that referenced
this pull request
Mar 30, 2024
…rd_party/chromium/media (#2724) Refer to the original PR: #2709 All modification to Chromium media code is guarded by `#if defined(STARBOARD)`. b/329702113 Co-authored-by: Bo-Rong Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All modification to Chromium media code is guarded by
#if defined(STARBOARD).b/329702113