[media] Revise OpusAudioDecoder::Reset() via OPUS_RESET_STATE #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
reset_opus_decoder
branch
from
530907d
to
2eb7ed5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
==========================================
- Coverage 59.74% 59.72% -0.03%
==========================================
Files 1825 1825
Lines 88124 88130 +6
==========================================
- Hits 52652 52634 -18
- Misses 35472 35496 +24 ☔ View full report in Codecov by Sentry. |
borongc
force-pushed
the
reset_opus_decoder
branch
2 times, most recently
from
4cd4d6d
to
d2ba8e8
Compare
borongc
force-pushed
the
reset_opus_decoder
branch
3 times, most recently
from
e01425d
to
84b2718
Compare
osagie98
approved these changes
Apr 1, 2024
borongc
force-pushed
the
reset_opus_decoder
branch
5 times, most recently
from
2e3809d
to
f4bcc20
Compare
borongc
force-pushed
the
reset_opus_decoder
branch
from
f4bcc20
to
45a715d
Compare
This PR (youtube#2501) recreating OpusAUdioDecoder in Reset(). Change to reset a previously initialized state using the #OPUS_RESET_STATE CTL as stated in the opus document. b/327281974
borongc
force-pushed
the
reset_opus_decoder
branch
from
45a715d
to
b398b29
Compare
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
This PR (#2501) recreates OpusAudioDecoder in OpusAudioDecoder::Reset(), as originally Cobalt recreates OpusAudioDecoder on PartialAudio tests. Change to reset a previously initialized state using the #OPUS_RESET_STATE CTL as stated in the opus document. b/327281974 (cherry picked from commit 8a15dd8)
andrewsavage1
pushed a commit
to andrewsavage1/cobalt
that referenced
this pull request
Apr 16, 2024
…e#2727) This PR (youtube#2501) recreates OpusAudioDecoder in OpusAudioDecoder::Reset(), as originally Cobalt recreates OpusAudioDecoder on PartialAudio tests. Change to reset a previously initialized state using the #OPUS_RESET_STATE CTL as stated in the opus document. b/327281974
borongc
added a commit
that referenced
this pull request
Apr 16, 2024
This PR (#2501) recreates OpusAudioDecoder in OpusAudioDecoder::Reset(), as originally Cobalt recreates OpusAudioDecoder on PartialAudio tests. Change to reset a previously initialized state using the #OPUS_RESET_STATE CTL as stated in the opus document. b/327281974 (cherry picked from commit 8a15dd8)
borongc
added a commit
that referenced
this pull request
Apr 17, 2024
…US_RESET_STATE (#2945) Refer to the original PR: #2727 This PR (#2501) recreates OpusAudioDecoder in OpusAudioDecoder::Reset(), as originally Cobalt recreates OpusAudioDecoder on PartialAudio tests. Change to reset a previously initialized state using the #OPUS_RESET_STATE CTL as stated in the opus document. b/327281974 Co-authored-by: Bo-Rong Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (#2501) recreates OpusAudioDecoder in OpusAudioDecoder::Reset(), as originally Cobalt recreates OpusAudioDecoder on PartialAudio tests. Change to reset a previously initialized state using the #OPUS_RESET_STATE CTL as stated in the opus document.
b/327281974