-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seek Latency Telemetry #2735
Conversation
Added the ability to track the latency of `WebMediaPlayer` actions to the existing `MediaMetricsProvider` class, and instrumented `Seek` as the first action. Added basic unit tests for the new code. b/329439521 Change-Id: Icbbfd0da148e48d2137da7662b91e6e2d52de590
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2735 +/- ##
==========================================
- Coverage 59.80% 59.79% -0.02%
==========================================
Files 1831 1831
Lines 88482 88482
==========================================
- Hits 52918 52907 -11
- Misses 35564 35575 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks clean, tests look good.
my only potential worry is any performance impact of calling IsActionCurrentlyTracked for every OnPipelineSeek, depending on how often seek is called.
base::small_map looks efficient though, so let's see!
lgtm if histogram data looks good for Joel
Change-Id: I4486d0fa7bcdc31ba12a549040e886044c53eeef
Change-Id: Ife49b0a7d40b809caf0f389a4230038dc8f6042e
Change-Id: If3ef45925049a43ee190e1bd65bdeae638d5d526
Change-Id: I4b1dc77751492846342a1c724f39f1b259d0eaae
Added the ability to track the latency of `WebMediaPlayer` actions to the existing `MediaMetricsProvider` class, and instrumented `Seek` as the first action. Added basic unit tests for the new code. b/329439521 Change-Id: Icbbfd0da148e48d2137da7662b91e6e2d52de590 (cherry picked from commit a712047)
Refer to the original PR: #2735 Added the ability to track the latency of `WebMediaPlayer` actions to the existing `MediaMetricsProvider` class, and instrumented `Seek` as the first action. Added basic unit tests for the new code. b/329439521 Change-Id: Icbbfd0da148e48d2137da7662b91e6e2d52de590 --------- Co-authored-by: Drew Thomas <[email protected]>
Added the ability to track the latency of
WebMediaPlayer
actions to the existingMediaMetricsProvider
class, and instrumentedSeek
as the first action.Added basic unit tests for the new code.
b/329439521
Change-Id: Icbbfd0da148e48d2137da7662b91e6e2d52de590