Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang 16 toolchain to linux workers. #2794

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

briantting
Copy link
Contributor

Resolves Buildbot failures for 24 lts builders that have not migrated to clang 17.

b/332306066

Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original change affected 7 files: #2680

I'm not sure if this single file change will fix issues.

Maybe it needs to hit all the dockerfiles in #2680

docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh seems like my previous comment was lost. As long as you are hitting all dockerfiles in original change that should be good. #2680

Also maybe add a TODO saying something like : // TODO(b/xxx) - Remove clang 16 once per branch dockerfiles are implemented correctly

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.82%. Comparing base (96283a0) to head (23defd2).
Report is 2 commits behind head on main.

❗ Current head 23defd2 differs from pull request most recent head a142c8f. Consider uploading reports for the commit a142c8f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2794      +/-   ##
==========================================
- Coverage   59.84%   59.82%   -0.02%     
==========================================
  Files        1839     1839              
  Lines       88460    88460              
==========================================
- Hits        52937    52925      -12     
- Misses      35523    35535      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Resolves Buildbot failures for 24 lts builders that have not migrated to
clang 17.

b/332306066
@kaidokert kaidokert merged commit 19a7161 into youtube:main Apr 1, 2024
312 of 313 checks passed
osagie98 pushed a commit to osagie98/cobalt that referenced this pull request Apr 1, 2024
Resolves Buildbot failures for 24 lts builders that have not migrated to
clang 17.

b/332306066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants