-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang 16 toolchain to linux workers. #2794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh seems like my previous comment was lost. As long as you are hitting all dockerfiles in original change that should be good. #2680
Also maybe add a TODO saying something like : // TODO(b/xxx) - Remove clang 16 once per branch dockerfiles are implemented correctly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2794 +/- ##
==========================================
- Coverage 59.84% 59.82% -0.02%
==========================================
Files 1839 1839
Lines 88460 88460
==========================================
- Hits 52937 52925 -12
- Misses 35523 35535 +12 ☔ View full report in Codecov by Sentry. |
Resolves Buildbot failures for 24 lts builders that have not migrated to clang 17. b/332306066
Resolves Buildbot failures for 24 lts builders that have not migrated to clang 17. b/332306066
Resolves Buildbot failures for 24 lts builders that have not migrated to clang 17.
b/332306066