-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Cobalt customizations to updated Chromium media #2854
Apply Cobalt customizations to updated Chromium media #2854
Conversation
Media now builds and links, but doesn't run. I'll list notes I jotted down during customization, I'll need to resolve most of these before it's complete:
|
f5fe786
to
84df2e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the primary commit message of the PR to include more details.
Change-Id: I94890e32576b62ff8dabfe6631541bed27c2e237
Change-Id: Ib6b6a47b36a8d8f20957253a627ddd24fd2f85d8
Change-Id: Iab0d473da2bf010906e23b615dd7a0f26171502b
Change-Id: If8f31e475f395e9194e9a3895cecc2282d2411b1
Change-Id: I95b6651afb168c610bdbf55e51107a34f09907ff
Change-Id: I2672833a74541c0ef93e25eb60007d62cf0af2e1
Change-Id: Ib11137f74cb717c590093ec8f9c74c1d0046f5a8
Also creates a //ui/gfx:gfx GN target. Change-Id: I2d7c38fef58d9e0c81582b1e0af21a11b64f83af
Change-Id: I8cf034408e682c0b5a2118b27a182b2e8132abe5
Change-Id: I71f1cbf9cf6c27b569841cb01c0435c72629e341
Apply customizations to //media so that Cobalt can build. b/319697087
be64058
to
2bb2c83
Compare
Fixes a build error with the media_sandbox target.
Change-Id: I0da38161e11dc0118a12ece369f885239f000bc5
Change-Id: I08e32d143799028052d6850ff364338840ed53d5
42cd30e
into
youtube:feature/media-upstream-update
Merges the feature/media-upstream-update branch to main. See the major commits to feature/media-upstream-update: - Import `//skia` from Chromium m114: #2816 - Update `//ui/gfx` to match Chromium m114: #2844 - Update `//media` to match Chromium m114: #2960 - Apply customizations to updated dependencies to build with Cobalt: #2854 b/319697087
This pull request modifies the
//media
directory to allow it to build with Cobalt. These modifications are guarded with `#if defined(STARBOARD).This pull request also includes the following changes:
//ui/gfx
and includes them in the build.Remaining gaps:
PipelineStatusCB
is planned to be replaced withPipelineStatusCallback
. We should update Cobalt media to use onlyPipelineStatusCallback
. Tracked in b/335673619b/319697087