Deprecate SB_HAS_QUIRK(SUPPORT_INT16_AUDIO_SAMPLES) #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
force-pushed
the
deprecate_int16
branch
from
3ebfe8f
to
c8320c2
Compare
kaidokert
approved these changes
Apr 15, 2024
jasonzhangxx
approved these changes
Apr 15, 2024
xiaomings
force-pushed
the
deprecate_int16
branch
from
c8320c2
to
b01981a
Compare
xiaomings
force-pushed
the
deprecate_int16
branch
from
b01981a
to
33de18c
Compare
SB_HAS_QUIRK(SUPPORT_INT16_AUDIO_SAMPLES) was introduced to allow platforms to use `kSbMediaAudioSampleTypeInt16` after it's deprecated. Now SB_HAS_QUIRK(SUPPORT_INT16_AUDIO_SAMPLES) was removed from Starboard 16, and platforms can no longer use `kSbMediaAudioSampleTypeInt16`. All platforms have to support float sample type in their AudioSink implementations, which will be verified by nplb. `kSbMediaAudioSampleTypeInt16Deprecated` is kept but will no longer be used by Cobalt, so the AudioSink implementations can continue to support int16 sample type for internal use. We may remove `SbMediaAudioSampleType` and `SbAudioSinkIsAudioSampleTypeSupported()` completely in a future release, and assume that the only sample type supported by AudioSink across the Starboard interface is int 16. This only affects the usage of int 16 samples in Cobalt, where the Starboard interface is the only channel to communicate to platform implementations. Platforms using AudioSink for video playback that also need to support int 16 sample type internally can continue to do so by defining their own types and enum values for int 16 sample type below Starboard. b/332054094 Change-Id: I8924ce5717e9d815aa46050c6e85488a8cdedc13
xiaomings
force-pushed
the
deprecate_int16
branch
from
33de18c
to
26701c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SB_HAS_QUIRK(SUPPORT_INT16_AUDIO_SAMPLES) was introduced to allow platforms to use
kSbMediaAudioSampleTypeInt16after it's deprecated.Now SB_HAS_QUIRK(SUPPORT_INT16_AUDIO_SAMPLES) was removed from Starboard 16, and platforms can no longer use
kSbMediaAudioSampleTypeInt16. All platforms have to support float sample type in their AudioSink implementations, which will be verified by nplb.kSbMediaAudioSampleTypeInt16Deprecatedis kept but will no longer be used by Cobalt, so the AudioSink implementations can continue to support int16 sample type for internal use. We may removeSbMediaAudioSampleTypeandSbAudioSinkIsAudioSampleTypeSupported()completely in a future release, and assume that the only sample type supported by AudioSink across the Starboard interface is int 16.This only affects the usage of int 16 samples in Cobalt, where the Starboard interface is the only channel to communicate to platform implementations. Platforms using AudioSink for video playback that also need to support int 16 sample type internally can continue to do so by defining their own types and enum values for int 16 sample type below Starboard.
b/332054094
Change-Id: I8924ce5717e9d815aa46050c6e85488a8cdedc13