Cherry pick PR #2875: [media] Fix failing to reset all status in AdaptiveAudioDecoder #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
approved these changes
Apr 12, 2024
1. This PR (#2287) returns an empyt DecodedAudio if it is end of stream. However, |first_input_written_| doesn't reset during AdaptiveAudioDecoder::ResetInternal(), causing it failed on AudioDecoderTest reset-related tests. 2. On ps5, |output_format_checked_| doesn't reset cause |resampler_| and |channel_mixer_| are nullptr, causing AudioDecoderTests fails. b/333416579 b/333412348 b/320568573 Test-On-Device: true (cherry picked from commit 32a2037)
borongc
force-pushed
the
cherry-pick-24.lts.1+-2875
branch
from
80405a9
to
86c708b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #2875
b/333416579
b/333412348
b/320568573
Test-On-Device: true