Fix websockets web platform tests #2961
Conversation
b/332367155
sherryzy
requested review from
jellefoks,
johnxwork,
aee-google and
andrewsavage1
There was a problem hiding this comment.
Great find! The wpt server's handling code could be this: http://shortn/_m7uNJrMDP3 Likely the wpt server changes the response file type or connection type when "pipe=sub" is provided. Something's not working and we are very close to the issue now, but we could debug that after the merge.
| @@ -2,7 +2,7 @@ | |||
| <title>WebSockets: Send/Receive blob, blob size less than network array buffer</title> | |||
| <script src=/resources/testharness.js></script> | |||
| <script src=/resources/testharnessreport.js></script> | |||
| <script src=../constants.js?pipe=sub></script> | |||
| <script src=../constants.js></script> | |||
There was a problem hiding this comment.
What does having/not having the pipe=sub mean?
There was a problem hiding this comment.
I'm not so sure, but see John's comments above. I just found it's changed in upstream here: https://chromium-review.googlesource.com/c/chromium/src/+/2848645 and it resolves the timeout issue. I'm still trying to understand the root cause, but we can figure it out later after the merge?
|
This may not be the correct fix. The real issue is currently version of wpt server doesn't support HTTP2, which cause those tests timeout. To fix the issue, we have to update web_platform_tests repo to a later version which requires a much larger effort. Close this fix for now. |
b/332367155