Cherry pick PR #3074: Filter target base_profiler_test on mac #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Target base_profiler_support_library is not applicable on mac. b/266705099 (cherry picked from commit 97032a3)
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-24.lts.1+-3074 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/8838025436 for details. |
PR3074 skips target base_profiler_test_support_library if building for Mac and is not Starboard.
maxz-lab
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3074
Target base_profiler_support_library is not applicable on mac.
b/266705099