Cherry pick PR #3057: Fix shared library install target dependency #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
approved these changes
Apr 25, 2024
b/335757361 Currently we need to run `ninja -C out/raspi-2_debug cobalt ; ninja -C out/raspi-2_debug cobalt_install` to build an installable target. This change fixes the install target build dependency so that `cobalt_install` depends on `cobalt` for modular installable targets so that we just need to run `ninja -C out/raspi-2_debug cobalt_install` to get an installable binary. (cherry picked from commit 25df9d7)
niranjanyardi
force-pushed
the
cherry-pick-24.lts.1+-3057
branch
from
0264fe6
to
b2d23bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3057
b/335757361
Currently we need to run
ninja -C out/raspi-2_debug cobalt ; ninja -C out/raspi-2_debug cobalt_installto build an installable target.
This change fixes the install target build dependency so that
cobalt_installdepends oncobaltfor modular installable targetsso that we just need to run
ninja -C out/raspi-2_debug cobalt_installto get an installable binary.