Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up SbFile usages #3243

Merged
merged 10 commits into from
Jun 20, 2024
Merged

Clean up SbFile usages #3243

merged 10 commits into from
Jun 20, 2024

Conversation

haozheng-cobalt
Copy link
Contributor

b/302715109

@haozheng-cobalt haozheng-cobalt self-assigned this May 14, 2024
@haozheng-cobalt haozheng-cobalt force-pushed the clean-file branch 12 times, most recently from 47f5349 to 07b07f5 Compare May 21, 2024 03:52
@haozheng-cobalt haozheng-cobalt force-pushed the clean-file branch 16 times, most recently from 47da9f6 to 641a153 Compare May 22, 2024 04:58
yjzhang111
yjzhang111 previously requested changes Jun 14, 2024
View reviewed changes
starboard/nplb/posix_compliance/posix_socket_send_test.cc Outdated Show resolved Hide resolved
base/files/file_unittest.cc Outdated Show resolved Hide resolved
base/logging.cc Outdated Show resolved Hide resolved
base/logging.cc Outdated Show resolved Hide resolved
cobalt/media/sandbox/format_guesstimator.cc Show resolved Hide resolved
starboard/common/file.h Outdated Show resolved Hide resolved
starboard/shared/starboard/player/filter/testing/file_cache_reader_test.cc Outdated Show resolved Hide resolved
starboard/shared/win32/posix_emu/include/fcntl.h Show resolved Hide resolved
y4vor
y4vor reviewed Jun 16, 2024
View reviewed changes
base/files/file_enumerator_unittest.cc Outdated Show resolved Hide resolved
base/files/file_enumerator_unittest.cc Show resolved Hide resolved
base/files/file_unittest.cc Outdated Show resolved Hide resolved
base/files/file_util_starboard.cc Outdated Show resolved Hide resolved
base/files/file_util_starboard.cc Outdated Show resolved Hide resolved
base/files/file_util_starboard.cc Outdated Show resolved Hide resolved
base/files/file_util_starboard.cc Outdated Show resolved Hide resolved
starboard/shared/win32/posix_emu/socket.cc Outdated Show resolved Hide resolved
@haozheng-cobalt haozheng-cobalt force-pushed the clean-file branch 2 times, most recently from 4e8063a to cff5ef6 Compare June 17, 2024 20:46
@haozheng-cobalt
Merge branch 'youtube:main' into clean-file
a47051d 
Change-Id: I46a7f8382608f20d6000af4a29d623df04db97a1
@haozheng-cobalt haozheng-cobalt dismissed yjzhang111’s stale review June 17, 2024 22:18

all comments resolved.

@haozheng-cobalt haozheng-cobalt removed the request for review from briantting June 17, 2024 22:31
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.94118% with 16 lines in your changes missing coverage. Please review.

Project coverage is 58.72%. Comparing base (84bd543) to head (4c77ad9).
Report is 12 commits behind head on main.

Files Patch % Lines
starboard/shared/starboard/link_receiver.cc 6.66% 14 Missing ⚠️
cobalt/renderer/test/png_utils/png_encode.cc 0.00% 1 Missing ⚠️
cobalt/speech/microphone_fake.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3243      +/-   ##
==========================================
- Coverage   58.74%   58.72%   -0.03%     
==========================================
  Files        1781     1781              
  Lines       85283    85324      +41     
==========================================
+ Hits        50099    50106       +7     
- Misses      35184    35218      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

y4vor
y4vor approved these changes Jun 19, 2024
View reviewed changes
starboard/common/file.h Show resolved Hide resolved
@haozheng-cobalt haozheng-cobalt enabled auto-merge (squash) June 20, 2024 16:11
@haozheng-cobalt
Merge branch 'main' into clean-file
4c77ad9 
Change-Id: I6ddacbbbafdf94235791bc501d9ff792ea83966e
@haozheng-cobalt haozheng-cobalt merged commit fd0c5ff into youtube:main Jun 20, 2024
338 of 368 checks passed
kaidokert added a commit that referenced this pull request Jun 21, 2024
@kaidokert
Revert "Clean up SbFile usages (#3243)"
8ae5c1d 
This reverts commit fd0c5ff.
@kaidokert kaidokert mentioned this pull request Jun 21, 2024
Closed
@kaidokert kaidokert added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jun 24, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 24, 2024
@haozheng-cobalt @anonymous1-me
Clean up SbFile usages (#3243)
bbc9d17 
b/302715109

(cherry picked from commit fd0c5ff)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 24, 2024
Closed
@kaidokert kaidokert added cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch and removed cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch labels Jun 24, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 24, 2024
@haozheng-cobalt @anonymous1-me
Clean up SbFile usages (#3243)
6201e6e 
b/302715109

(cherry picked from commit fd0c5ff)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 24, 2024
Merged
kaidokert pushed a commit that referenced this pull request Jun 24, 2024
@haozheng-cobalt @kaidokert
Clean up SbFile usages (#3243)
51b715e 
b/302715109

(cherry picked from commit fd0c5ff)
kaidokert pushed a commit that referenced this pull request Jun 24, 2024
@cobalt-github-releaser-bot @haozheng-cobalt
Cherry pick PR #3243: Clean up SbFile usages (#3652)
b8b8fa3 
Refer to the original PR: #3243

b/302715109

Co-authored-by: Hao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert left review comments

@yjzhang111 yjzhang111 yjzhang111 left review comments

@gbournou gbournou gbournou left review comments

@y4vor y4vor y4vor approved these changes

@briantting briantting briantting approved these changes

@andrewsavage1 andrewsavage1 Awaiting requested review from andrewsavage1

Assignees

@haozheng-cobalt haozheng-cobalt

Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch on_device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haozheng-cobalt @y4vor @briantting @kaidokert @yjzhang111 @gbournou