Enable on-device tests for evergreen AOSP #3247
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantting
approved these changes
May 14, 2024
oxve
force-pushed
the
evergreen-arm-builders
branch
from
44aee2d
to
8d8de60
Compare
johnxwork
approved these changes
May 16, 2024
oxve
force-pushed
the
evergreen-arm-builders
branch
from
67b2a6e
to
476c94b
Compare
oxve
changed the title
oxve
commented
May 20, 2024
| target_name != "nplb_evergreen_compat_tests" && | ||
| target_name != "player_filter_benchmarks" && | ||
| # TODO: This one looks fishy. | ||
| target_name != "player_filter_tests" && |
There was a problem hiding this comment.
This is expected. Per @andrewsavage1 the test suite was disabled because it depends too much on the starboard implementation.
oxve
force-pushed
the
evergreen-arm-builders
branch
20 times, most recently
from
fdc6ec0
to
b0fec46
Compare
b/291130824
Change-Id: I715f754fc40573584523009eb538cf43432f4b3b
Change-Id: Ibece0510d5e1ad9dd4f63a2f3ff10913739b0bf1
Change-Id: Ica6b7a17a1d3c7ad77025c6a954070c7acf139d9
Change-Id: I3c5b13a3d8fad52175c91f8923ff6dd83f94c946
Change-Id: Ia34dda84ff18817ecd019fb06c324af246d1d3a1
oxve
force-pushed
the
evergreen-arm-builders
branch
from
b0fec46
to
d9d046b
Compare
yuying-y
reviewed
Jul 17, 2024
| gradle_files_dir = "$root_out_dir/gradle/$installable_target_name" | ||
| # The gradle build expects libcrashpad_handler.so to be present in the out directory. | ||
| if (sb_is_evergreen_compatible) { | ||
| deps += [ "//starboard/loader_app:copy_crashpad_handler_named_as_so" ] |
There was a problem hiding this comment.
The crashpad_handler target is not needed for unit test targets. Removing the dependency will save us some space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/268244534
b/291130824