Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move glimp to internal #3333

Merged
merged 1 commit into from
May 25, 2024
Merged

Move glimp to internal #3333

merged 1 commit into from
May 25, 2024

Conversation

dahlstrom-g
Copy link
Contributor

Fixed: 153441349

@dahlstrom-g
Move glimp to internal
48e4d40 
Fixed: 153441349
@kaidokert
Copy link
Member

Note, internal CL go/cobalt-cl/283401

kaidokert
kaidokert approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

After this goes in, we may want to think if we can somehow refactor the changes in graphics_system.cc as well so it doesn't directly refer to internal code. Not sure what that would look like exactly.

@dahlstrom-g dahlstrom-g merged commit 9be7498 into youtube:main May 25, 2024
308 of 309 checks passed
@dahlstrom-g dahlstrom-g deleted the glimp branch May 25, 2024 22:00
@dahlstrom-g dahlstrom-g added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label May 31, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 31, 2024
@dahlstrom-g @anonymous1-me
Move glimp to internal
ffbfb55 
Fixed: 153441349
Reviewed-on: #3333
(cherry picked from commit 9be7498)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request May 31, 2024
Merged
dahlstrom-g added a commit that referenced this pull request May 31, 2024
@dahlstrom-g
Move glimp to internal
5d744ee 
(cherry picked from commit 9be7498)

Fixed: 153441349
Reviewed-on: #3333
dahlstrom-g pushed a commit that referenced this pull request May 31, 2024
@cobalt-github-releaser-bot
Move glimp to internal
b8b679d 
(cherry picked from commit 9be7498)

Fixed: 153441349
Reviewed-on: #3333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

Assignees
No one assigned
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dahlstrom-g @kaidokert