Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IAMF v1.0.0 errata changes #3337

Draft
wants to merge 4 commits into
base: 24.lts.1+
Choose a base branch
from
Draft

Implement IAMF v1.0.0 errata changes #3337

wants to merge 4 commits into from

Commits on Jun 13, 2024

  1. [media] Implement IAMF audio parsing (youtube#2279) 

    Cherry-picks
https://chromium-review.googlesource.com/c/chromium/src/+/5128755 and
adds minor changes to allow it to build.
Original CL description follows.

Adds an IAMF codec definition and implements IAMF MP4 parsing for
v1.0.0. The implementation is disabled by default.

Immersive Audio Model and Formats v1.0.0
https://aomediacodec.github.io/iamf/v1.0.0.html

b/271301103

Removes string_view to build on 24.lts.
    @osagie98
    osagie98 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    36bbb90 View commit details
    Browse the repository at this point in the history

  2. [media] Enable Cobalt support of IAMF (youtube#2297) 

    Has Cobalt recognize the Chrome `AudioCodec::kIAMF` as the Cobalt
`kSbMediaAudioCodecIamf`, allowing Cobalt to handle IAMF streams.

b/271301103
    @osagie98
    osagie98 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    06d7f26 View commit details
    Browse the repository at this point in the history

  3. Implement IAMF v1.0.0 errata changes 

    Updates the IAMF mp4 parsing implementation to support v1.0.0-errata.
Streams configured with the original v1.0.0 spec are no longer
supported.

Changes are pulled from Chromium. Original CL descriptions follow:

Update IAMF mp4 parsing implementation

Updates the IAMF parsing implemenation to parse the IA Configuration Box
defined in the IAMF v1.0.0-errata specification.

https://aomediacodec.github.io/iamf/v1.0.0-errata.html#iaconfigurationbox-section

Bug: b/340618404
Change-Id: I1467e60928ac28e0ead4a9e0f3857b6c5540c7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5550540
Reviewed-by: Mark Foltz <[email protected]>
Commit-Queue: Austin Osagie <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304144}

Fix iacb atom parsing error

Fixes an error in a previous change that parses the iamf atom instead of
the iacb atom. Now, the iacb atom is properly read.

Bug: b/340618404
Change-Id: I61d8c8c2758c9181b40ff6e99da24c790b202687
    @osagie98
    osagie98 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    7e91a6f View commit details
    Browse the repository at this point in the history

  4. Add Starboard utils logging

    @osagie98
    osagie98 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c0bc2b7 View commit details
    Browse the repository at this point in the history