Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove starboard/common/file usage above Starboard. #3412

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Remove starboard/common/file usage above Starboard. #3412

merged 1 commit into from
Jun 12, 2024

Conversation

iuriionishchenko
Copy link
Collaborator

b/322248208

Change-Id: I542c1da859e4ed615477887965030e4ff5bd8a9d

@iuriionishchenko iuriionishchenko force-pushed the Remove_starboard.common.file_continuing branch from 58fbe73 to 21762e4 Compare May 31, 2024 13:16
@kaidokert
Copy link
Member

Looks like a real test failure on Evergreen - please test with evergreen-x64 to see where the unsupported flag issue comes from.

@iuriionishchenko
Copy link
Collaborator Author

Looks like a real test failure on Evergreen - please test with evergreen-x64 to see where the unsupported flag issue comes from.

Can you share additional information about Evergreen or documents (documents more preferable)? How can I build and run it on local PC? Which platforms are supported? I've never used Evergreen before.

@kaidokert
Copy link
Member

Looks like a real test failure on Evergreen - please test with evergreen-x64 to see where the unsupported flag issue comes from.

Can you share additional information about Evergreen or documents (documents more preferable)? How can I build and run it on local PC? Which platforms are supported? I've never used Evergreen before.

I posted comments on the bug how to debug this.

@iuriionishchenko iuriionishchenko force-pushed the Remove_starboard.common.file_continuing branch 5 times, most recently from 34720ae to 65dc7d7 Compare June 11, 2024 08:13
@iuriionishchenko
Remove starboard/common/file usage above Starboard.
5368c00 
b/322248208

Change-Id: I542c1da859e4ed615477887965030e4ff5bd8a9d
@iuriionishchenko iuriionishchenko force-pushed the Remove_starboard.common.file_continuing branch from 65dc7d7 to 5368c00 Compare June 12, 2024 10:24
@kaidokert kaidokert merged commit 6eba837 into youtube:main Jun 12, 2024
317 of 318 checks passed
@kaidokert kaidokert added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jun 12, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 12, 2024
@iuriionishchenko @anonymous1-me
Remove starboard/common/file usage above Starboard. (#3412)
b2724c0 
b/322248208

Change-Id: I542c1da859e4ed615477887965030e4ff5bd8a9d
(cherry picked from commit 6eba837)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 12, 2024
Closed
@kaidokert kaidokert added cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch and removed cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch labels Jun 13, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 13, 2024
@iuriionishchenko @anonymous1-me
Remove starboard/common/file usage above Starboard. (#3412)
b8158a6 
b/322248208

Change-Id: I542c1da859e4ed615477887965030e4ff5bd8a9d
(cherry picked from commit 6eba837)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 13, 2024
Merged
kaidokert pushed a commit that referenced this pull request Jun 13, 2024
@iuriionishchenko @kaidokert
Remove starboard/common/file usage above Starboard. (#3412)
7d85a37 
b/322248208

Change-Id: I542c1da859e4ed615477887965030e4ff5bd8a9d
(cherry picked from commit 6eba837)
kaidokert pushed a commit that referenced this pull request Jun 13, 2024
@cobalt-github-releaser-bot @iuriionishchenko
Cherry pick PR #3412: Remove starboard/common/file usage above Starbo…
f5c97a6 
…ard. (#3548)

Refer to the original PR: #3412

b/322248208

Change-Id: I542c1da859e4ed615477887965030e4ff5bd8a9d

Co-authored-by: iuriionishchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

Assignees
No one assigned
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuriionishchenko @kaidokert