Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loader app load updated system image directly #3421

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Make loader app load updated system image directly #3421

merged 1 commit into from
Jul 19, 2024

Conversation

yuying-y
Copy link
Contributor

@yuying-y yuying-y commented Jun 1, 2024 •
edited by kaidokert
Loading

b/344069914
b/328421395

@yuying-y yuying-y force-pushed the load_sys branch 4 times, most recently from a22fb2c to d2d9121 Compare June 4, 2024 23:39
@yuying-y yuying-y requested a review from y4vor June 4, 2024 23:40
@yuying-y
Copy link
Contributor Author

yuying-y commented Jun 4, 2024

Tested and verified on Linux

@yuying-y yuying-y force-pushed the load_sys branch 5 times, most recently from 34d92d3 to 64b47ef Compare June 24, 2024 21:13
@yuying-y yuying-y force-pushed the load_sys branch 2 times, most recently from 97d8b74 to fcdb2c4 Compare July 9, 2024 23:04
@yuying-y yuying-y requested a review from y4vor July 9, 2024 23:06
@y4vor y4vor requested a review from hlwarriner July 12, 2024 15:58
hlwarriner
hlwarriner reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@hlwarriner hlwarriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good - just left a few style comments, mostly about the tests. Thanks for the solid unit test coverage.

starboard/loader_app/slot_management.cc Show resolved Hide resolved
starboard/loader_app/slot_management_test.cc Show resolved Hide resolved
starboard/loader_app/slot_management_test.cc Show resolved Hide resolved
starboard/loader_app/slot_management_test.cc Show resolved Hide resolved
starboard/loader_app/slot_management.cc Show resolved Hide resolved
@yuying-y
Make loader app load updated system image directly
c7ad119 
b/344069914
b/328421395

Change-Id: I66734aed7b52bac4b60e823df4873c5dccc8c0f2
@hlwarriner hlwarriner self-requested a review July 17, 2024 14:26
@yuying-y yuying-y merged commit 651b4fe into youtube:main Jul 19, 2024
328 of 329 checks passed
@yuying-y yuying-y added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jul 19, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jul 19, 2024
@yuying-y @anonymous1-me
Make loader app load updated system image directly (#3421)
3f1d99a 
b/344069914
b/328421395

(cherry picked from commit 651b4fe)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jul 19, 2024
Merged
yuying-y added a commit that referenced this pull request Jul 23, 2024
@yuying-y
Make loader app load updated system image directly (#3421)
6ed956d 
b/344069914
b/328421395

(cherry picked from commit 651b4fe)
yuying-y added a commit that referenced this pull request Jul 23, 2024
@cobalt-github-releaser-bot @yuying-y
Cherry pick PR #3421: Make loader app load updated system image direc…
5a088e7 
…tly (#3859)

Refer to the original PR: #3421

b/344069914
b/328421395

Co-authored-by: yuying-y <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y4vor y4vor y4vor approved these changes

@kaidokert kaidokert kaidokert approved these changes

@hlwarriner hlwarriner hlwarriner approved these changes

Assignees
No one assigned
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuying-y @y4vor @kaidokert @hlwarriner