-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for verify the crash handler yts case fail [1/1] #3425
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
third_party/crashpad/crashpad/util/net/http_transport_socket.cc
Outdated
Show resolved
Hide resolved
third_party/crashpad/crashpad/util/net/http_transport_socket.cc
Outdated
Show resolved
Hide resolved
Hi Hyobo, would you cc Holden and me on the issue you linked above? We need to check the stack trace and make sure you get the best fix. |
Issue link: https://partnerissuetracker.corp.google.com/u/0/issues/323792488 Problem: Evergreen Full verify the crash handler functionality case fail Solution: When the device network did not support ipv6,use ipv4 to create socket Verify: Local test Signed-off-by: Hyobo <[email protected]>
third_party/crashpad/crashpad/util/net/http_transport_socket.cc
Outdated
Show resolved
Hide resolved
@hlwarriner Thks~ |
@hlwarriner @johnxwork |
Sorry, what's the issue? I do have an outstanding question I asked in https://partnerissuetracker.corp.google.com/u/0/issues/323792488#comment7. Can you please take a look? Thanks |
@hlwarriner |
@hlwarriner If platform only support IPV4. and the member of function getaddrinfo() is AF_INET6. the creatsocket return null fd.and test case fail. As we known ,there are several reasons which caused the first member of getaddtinfo() return AF_INET6.. system configuration,dns parser,perfer setting and so on. |
@hlwarriner Could you help to check it again? |
Issue link:
https://partnerissuetracker.corp.google.com/u/0/issues/323792488
Problem:
Evergreen Full verify the crash handler functionality case fail
Solution:
When the device network did not support ipv6,use ipv4 to create socket
Verify:
Local test
b/323792488