Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for verify the crash handler yts case fail [1/1] #3425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hyobo
Copy link
Contributor

@Hyobo Hyobo commented Jun 3, 2024

Issue link:
https://partnerissuetracker.corp.google.com/u/0/issues/323792488

Problem:
Evergreen Full verify the crash handler functionality case fail

Solution:
When the device network did not support ipv6,use ipv4 to create socket

Verify:
Local test

b/323792488

Copy link

google-cla bot commented Jun 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kaidokert kaidokert requested review from johnxwork and hlwarriner and removed request for johnxwork June 13, 2024 17:21
@johnxwork
Copy link
Contributor

Hi Hyobo, would you cc Holden and me on the issue you linked above? We need to check the stack trace and make sure you get the best fix.

Issue link:
https://partnerissuetracker.corp.google.com/u/0/issues/323792488

Problem:
Evergreen Full verify the crash handler functionality case fail

Solution:
When the device network did not support ipv6,use ipv4 to create socket

Verify:
Local test

Signed-off-by: Hyobo <[email protected]>
@Hyobo
Copy link
Contributor Author

Hyobo commented Jun 24, 2024

@hlwarriner
The yts tets case mainly test dump file upload mechanism work well or not via crashpad_handler process.
third_party\crashpad\handler\crash_report_upload_thread.cc -> UploadReport()
http_transport_socket.cc -> ExecuteSynchronously()
http_transport_socket.cc -> CreateSocket()

Thks~

@kaidokert kaidokert requested a review from johnxwork July 8, 2024 17:47
@Hyobo
Copy link
Contributor Author

Hyobo commented Jul 16, 2024

@hlwarriner @johnxwork
I can not get the information about the "Unresolved conversations"
Could you help me to pass it?
Thks~

@hlwarriner
Copy link
Contributor

@hlwarriner @johnxwork I can not get the information about the "Unresolved conversations" Could you help me to pass it? Thks~

Sorry, what's the issue?

I do have an outstanding question I asked in https://partnerissuetracker.corp.google.com/u/0/issues/323792488#comment7. Can you please take a look?

Thanks

@Hyobo
Copy link
Contributor Author

Hyobo commented Jul 17, 2024

@hlwarriner
Many thks for your information,
I have updated the comment https://partnerissuetracker.corp.google.com/u/0/issues/323792488#comment8

@Hyobo
Copy link
Contributor Author

Hyobo commented Jul 22, 2024

@hlwarriner
Thks for your informaiton.
We also update the comment below at the ticket https://partnerissuetracker.corp.google.com/issues/323792488
ScopedSetNonblocking nonblocking(result.get()); ->no blocking mode
Connect() will return ‘EINPROGRESS’.and goto the WaitUntilSocketIsReady().
WaitUntilSocketIsReady() poll error,will return false always.(we also try to add the timeout threshold).

If platform only support IPV4. and the member of function getaddrinfo() is AF_INET6. the creatsocket return null fd.and test case fail.

As we known ,there are several reasons which caused the first member of getaddtinfo() return AF_INET6.. system configuration,dns parser,perfer setting and so on.

@Hyobo
Copy link
Contributor Author

Hyobo commented Jul 29, 2024

questing changes by reviewers w

@hlwarriner Could you help to check it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants