Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase WebDriverServer max buffer size. #3432

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

briantting
Copy link
Contributor

Resolves timeout issues when screenshots exceed the default 1mb buffer size and are unable to be sent.

b/344007302

Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look wrong to me, at least to get around the current blockers.

Resolves timeout issues when screenshots exceed the default 1mb buffer
size and are unable to be sent.

b/344007302
@kaidokert kaidokert merged commit 4172b4d into youtube:main Jun 4, 2024
307 of 309 checks passed
@kaidokert kaidokert added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jun 4, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 4, 2024
Resolves timeout issues when screenshots exceed the default 1mb buffer
size and are unable to be sent.

b/344007302

(cherry picked from commit 4172b4d)
kaidokert pushed a commit that referenced this pull request Jun 4, 2024
Refer to the original PR: #3432

Resolves timeout issues when screenshots exceed the default 1mb buffer
size and are unable to be sent.

b/344007302

Co-authored-by: Brian Ting <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants