Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Base cleanups" #3433

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Revert "Base cleanups" #3433

merged 1 commit into from
Jun 4, 2024

Conversation

kaidokert
Copy link
Member

This seems to have broken all devel/debug builds. Needs a rebase on trunk.

Reverts #3361

gbournou
gbournou approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@gbournou gbournou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts most of the original CL, but leaves the change to third_party/protobuf/BUILD.gn. Was that intentional?

@kaidokert kaidokert merged commit 9bc5ee3 into main Jun 4, 2024
302 of 305 checks passed
@kaidokert kaidokert deleted the revert-3361-cleanup/base branch June 4, 2024 00:06
@kaidokert
Copy link
Member Author

This reverts most of the original CL, but leaves the change to third_party/protobuf/BUILD.gn. Was that intentional?

I don't know actually, i didn't change the revert at all, just pushed the button in the UI. No idea how that happened

andrewsavage1 added a commit that referenced this pull request Jun 4, 2024
@andrewsavage1
Revert "Revert "Base cleanups" (#3433)"
344b153 
This reverts commit 9bc5ee3.
andrewsavage1 added a commit that referenced this pull request Jun 4, 2024
@andrewsavage1
Revert "Revert "Base cleanups" (#3433)" (#3435)
104d3cf 
This reverts commit 9bc5ee3.

b/334975532
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 4, 2024
@andrewsavage1 @anonymous1-me
Revert "Revert "Base cleanups" (#3433)" (#3435)
288d0a9 
This reverts commit 9bc5ee3.

b/334975532

(cherry picked from commit 104d3cf)
andrewsavage1 added a commit that referenced this pull request Jun 6, 2024
@cobalt-github-releaser-bot @andrewsavage1
Cherry pick PR #3435: Revert "Revert "Base cleanups" (#3433)" (#3448)
4de5a44 
Refer to the original PR: #3435

This reverts commit 9bc5ee3.

b/334975532

---------

Co-authored-by: Andrew Savage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

@gbournou gbournou gbournou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaidokert @andrewsavage1 @gbournou