Add back SbMemoryGetStackBounds for EG AOSP #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y4vor
reviewed
Jun 4, 2024
This API is needed for running EG AOSP for SB < 15 b/341636739 Change-Id: Ied03b5574d48d9380fd1e7b067cb8c5f02fb6a37
Yes, but it should work with SB14, C24. See details in b/341636739. It should be kept in the BUILD.gn similar to https://source.corp.google.com/h/lbshell-internal/cobalt_src/+/COBALT:starboard/linux/shared/BUILD.gn;l=136 |
C24 doesn't use SbMemoryGetStackBounds. |
gbournou
approved these changes
Jun 5, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
This API is needed for running EG AOSP for SB < 15 b/341636739 Change-Id: Ied03b5574d48d9380fd1e7b067cb8c5f02fb6a37 (cherry picked from commit fbf1d05)
yuying-y
added a commit
that referenced
this pull request
Jun 6, 2024
This API is needed for running EG AOSP for SB < 15 b/341636739 Change-Id: Ied03b5574d48d9380fd1e7b067cb8c5f02fb6a37 (cherry picked from commit fbf1d05)
yuying-y
added a commit
that referenced
this pull request
Jun 11, 2024
This API is needed for running EG AOSP for SB < 15 b/341636739 Change-Id: Ied03b5574d48d9380fd1e7b067cb8c5f02fb6a37 (cherry picked from commit fbf1d05)
yuying-y
added a commit
that referenced
this pull request
Jun 12, 2024
) Refer to the original PR: #3434 This API is needed for running EG AOSP for SB < 15 b/341636739 Change-Id: Ied03b5574d48d9380fd1e7b067cb8c5f02fb6a37 Co-authored-by: yuying-y <[email protected]>
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
This API is needed for running EG AOSP for SB < 15 b/341636739 Change-Id: Ied03b5574d48d9380fd1e7b067cb8c5f02fb6a37 (cherry picked from commit fbf1d05)
kaidokert
pushed a commit
that referenced
this pull request
Aug 15, 2024
) Refer to the original PR: #3434 This API is needed for running EG AOSP for SB < 15 b/341636739 Change-Id: Ied03b5574d48d9380fd1e7b067cb8c5f02fb6a37 Co-authored-by: yuying-y <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is needed for running EG AOSP for SB < 15
b/341636739
Change-Id: Ied03b5574d48d9380fd1e7b067cb8c5f02fb6a37