Cherry pick PR #3501: Fix starboard_platform_tests install target dependency #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/345848337 starboard_platform_tests_install was being excluded from the build graph as it didn't have any target depending on it. This change adds a dependency on "starboard_platform_tests_install" Test-On-Device: true (cherry picked from commit 515d982)
niranjanyardi
approved these changes
Jun 11, 2024
auto-merge was automatically disabled
July 10, 2024 00:30
Pull Request is not mergeable
auto-merge was automatically disabled
July 10, 2024 00:31
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3501
b/345848337
starboard_platform_tests_install was being excluded from the build graph as it didn't have any target depending on it.
This change adds a dependency on "starboard_platform_tests_install"
Test-On-Device: true