Cherry pick PR #3707: Add ArtworkDownloader interface #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract and refactor the part of the code in ArtworkLoader to a new interface ArtworkDownloader and its default implementation ArtworkDownloaderDefault, so that we could swap the implementation in Kimono to avoid GMS Extract the artwork downloading functionality from ArtworkLoader into a separate interface (ArtworkDownloader) and a default implementation (ArtworkDownloaderDefault). This will allow the Kimono project to provide its own implementation without relying on GMS dependencies. b/347963541 Change-Id: I7edd475991c7dd755aa24f313aaa890db4d5798d Co-authored-by: Colin Liang <[email protected]> (cherry picked from commit 1f75c29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3707
Extract and refactor the part of the code in ArtworkLoader to a new interface ArtworkDownloader and its default implementation ArtworkDownloaderDefault, so that we could swap the implementation in Kimono to avoid GMS Extract the artwork downloading functionality from ArtworkLoader into a separate interface (ArtworkDownloader) and a default implementation
(ArtworkDownloaderDefault). This will allow the Kimono project to provide its own implementation without relying on GMS dependencies.
b/347963541
Change-Id: I7edd475991c7dd755aa24f313aaa890db4d5798d