Cherry pick PR #3939: Print an error message and return instead of crash #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd (cherry picked from commit 7a23f54)
yuying-y
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3939
When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image.
b/357947368
Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd