Make nplb part of default target
#4024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To confirm the change, what command should I use to build default target? |
Either |
|
@niranjanyardi Do you know what all the missing symbols are about? |
Change-Id: I433a8b7d4bd8054600c74daa12180ada11a443bc
niranjanyardi
force-pushed
the
make_nplb_build_in_default
branch
from
c61061c
to
8f7a8c8
Compare
it's very weird, im doing a rebase and trying again. |
|
Submitting change in 25lts: #4057 and then cherry-picking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/360953120
We plan on releasing
nplbevergreen binaries to partners. This change adds it to thedefaulttarget which gets currently built on github.Remove
test_only = truefrom nplb and it's dependencies as these binaries will be eventually released to production.