Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove //cobalt dependency from Starboard #4084

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Remove //cobalt dependency from Starboard #4084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cobalt/renderer/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ static_library("renderer") {
"//starboard/content/fonts:copy_font_data",
]

if (is_starboard) {
deps += [ default_renderer_options_dependency ]
}
deps += [ "//cobalt/renderer:default_options" ]

if (!is_gold) {
deps += [ "//cobalt/debug:console_command_manager" ]
Expand Down
1 change: 0 additions & 1 deletion cobalt/site/docs/reference/starboard/gn-configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Book: /youtube/cobalt/_book.yaml
| **`cobalt_licenses_platform`**<br><br> Sub-directory to copy license file to.<br><br>The default value is `"default"`. |
| **`cobalt_platform_dependencies`**<br><br> List of platform-specific targets that get compiled into cobalt.<br><br>The default value is `[]`. |
| **`cobalt_v8_emit_builtins_as_inline_asm`**<br><br> Some compiler can not compile with raw assembly(.S files) and v8 converts asm to inline assembly for these platforms.<br><br>The default value is `false`. |
| **`default_renderer_options_dependency`**<br><br> Override this value to adjust the default rasterizer setting for your platform.<br><br>The default value is `"//cobalt/renderer:default_options"`. |
| **`enable_in_app_dial`**<br><br> Enables or disables the DIAL server that runs inside Cobalt. Note: Only enable if there's no system-wide DIAL support.<br><br>The default value is `false`. |
| **`executable_configs`**<br><br> Target-specific configurations for executable targets.<br><br>The default value is `[]`. |
| **`final_executable_type`**<br><br> The target type for executable targets. Allows changing the target type on platforms where the native code may require an additional packaging step (ex. Android).<br><br>The default value is `"executable"`. |
Expand Down
4 changes: 0 additions & 4 deletions starboard/build/config/base_configuration.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,6 @@ declare_args() {
# Note: Only enable if there's no system-wide DIAL support.
enable_in_app_dial = false

# Override this value to adjust the default rasterizer setting for your
# platform.
default_renderer_options_dependency = "//cobalt/renderer:default_options"

# A symbolizer path for ASAN can be added to allow translation of callstacks.
asan_symbolizer_path = "$clang_base_path/bin/llvm-symbolizer"

Expand Down
Loading