Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move download_from_gcs to Starboard #4086

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Move download_from_gcs to Starboard #4086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ repos:
always_run: true
stages: [push]
additional_dependencies: [certifi]
args: [-m, unittest, cobalt/tools/download_from_gcs_test.py]
args: [-m, unittest, starboard/tools/download_from_gcs_test.py]
- id: test-python3-compatibility
name: Test Python 3 Compatibility
description: Checks that scripts can be run in Python 3
Expand Down
2 changes: 1 addition & 1 deletion cobalt/media/testing/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import("//cobalt/media/testing/data/sha1_files.gni")
action("cobalt_media_download_test_data") {
install_content = true

script = "//cobalt/tools/download_from_gcs.py"
script = "//starboard/tools/download_from_gcs.py"

sha_sources = []
foreach(sha1_file, sha1_files) {
Expand Down
2 changes: 1 addition & 1 deletion cobalt/renderer/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ copy("renderer_copy_lottie_test_data") {
action("renderer_download_lottie_test_data") {
install_content = true

script = "//cobalt/tools/download_from_gcs.py"
script = "//starboard/tools/download_from_gcs.py"

inputs = [
"$_lottie_resource_path/finger_print-expected.png.sha1",
Expand Down
2 changes: 1 addition & 1 deletion components/crx_file/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if (is_starboard) {
action("crx_file_download_test_data") {
install_content = true

script = "//cobalt/tools/download_from_gcs.py"
script = "//starboard/tools/download_from_gcs.py"

sha_sources = []
foreach(sha1_file, sha1_files) {
Expand Down
2 changes: 1 addition & 1 deletion download_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
except ImportError:
import urllib2 as urllib

from cobalt.tools import download_from_gcs
from starboard.tools import download_from_gcs


def DownloadGerritCommitMsgHook(force=False):
Expand Down
2 changes: 1 addition & 1 deletion starboard/shared/starboard/player/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ static_library("video_dmp") {
action("player_download_test_data") {
install_content = true

script = "//cobalt/tools/download_from_gcs.py"
script = "//starboard/tools/download_from_gcs.py"

sha_sources = []
foreach(sha1_file, sha1_files) {
Expand Down
0 cobalt/tools/download_from_gcs.py → starboard/tools/download_from_gcs.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion cobalt/tools/download_from_gcs_test.py → starboard/tools/download_from_gcs_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import tempfile
import unittest

from cobalt.tools import download_from_gcs
from starboard.tools import download_from_gcs

_BUCKET = 'chromium-clang-format'
_HASH_FILE_EXT = '.sha1'
Expand Down
0 ...sting/download_from_gcs/clang-format.sha1 → ...sting/download_from_gcs/clang-format.sha1
View file
Open in desktop
File renamed without changes.
0 ...d_from_gcs/test_dir/clang-format.exe.sha1 → ...d_from_gcs/test_dir/clang-format.exe.sha1
View file
Open in desktop
File renamed without changes.
0 ...nload_from_gcs/test_dir/clang-format.sha1 → ...nload_from_gcs/test_dir/clang-format.sha1
View file
Open in desktop
File renamed without changes.
Loading