Cherry pick PR #4068: [telemetry] Add telemetry to SbPlayer functions #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-25.lts.1+-4068 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/10741745083 for details. |
borongc
reviewed
Sep 11, 2024
borongc
reviewed
Sep 11, 2024
borongc
force-pushed
the
cherry-pick-25.lts.1+-4068
branch
from
7ddb17c
to
4c203ca
Compare
borongc
approved these changes
Sep 12, 2024
Adding additional Media Telemetry to cover SbPlayer functions. The rough range of each function: 1. SbPlayerGetPreferredOutputMode(): 1.5us to 13us 2. SbPlayerSeek(): 6us to 318us 3. SbPlayerWriteEndOfStream()/audio: 13us to 6.3ms 4. SbPlayerWriteEndOfStream()/video: 3us to 2.8ms 5. SbPlayerSetBounds(): 133us to 26.95ms 6. SbPlayerSetPlaybackRate(): 6us to 11.17ms 7. SbPlayerSetVolume(): 7us to 17.89ms 8. SbPlayerGetInfo(): 1us to 6.8ms 9. SbPlayerGetAudioConfiguration(): 2us to 22.7ms 10. SbPlayerGetCurrentFrame(): 5us to 61.7ms b/303328238 (cherry picked from commit ea15d82)
borongc
force-pushed
the
cherry-pick-25.lts.1+-4068
branch
from
4c203ca
to
bd7aada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #4068
Adding additional Media Telemetry to cover SbPlayer functions.
The rough range of each function:
b/303328238