Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick PR #3801: Add state setters to MediaSourceAttachment #4103

Closed

Commits on Sep 11, 2024

  1. Add state setters to MediaSourceAttachment (#3801)

    In preparation for cross-thread MediaSource objects, a small amount of
    state and associated setters are being added to the
    MediaSourceAttachment interface. This will allow for a push model,
    instead of a pull model, for state such as recent media timestamps, and
    the error status of the HTMLMediaElement.
    
    Usage of these setters is gated through the
    `"MediaElement.EnableUsingMediaSourceAttachmentMethods"` H5VCC flag.
    This flag needs to be coordinated between a `HTMLMediaElement`, the
    attached `MediaSource`, and all `SourceBuffers` used. As such, the value
    of the flag when the `HTMLMediaElement` was created is used to
    coordinate the state of the rest of the related objects. This prevents a
    flag mismatch, such as if the H5VCC value is updated after the
    `HTMLMediaElement` has been created but before the `MediaSource` is
    created.
    
    This is based off of the following Chromium changes:
    
    *  https://chromium-review.googlesource.com/c/chromium/src/+/2391934
    *  https://chromium-review.googlesource.com/c/chromium/src/+/2401808
    
    b/338425449
    
    (cherry picked from commit e462633)
    at-ninja authored and anonymous1-me committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    551dff0 View commit details
    Browse the repository at this point in the history