-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete deprecated starboard header files #4106
Delete deprecated starboard header files #4106
Conversation
Change-Id: I8c56ca7c5024e148f625756a626884b9daf31ce2
Change-Id: Iac1a5679cf2d81d73d3e4a2b73d04b135ad7fedb
Change-Id: I18bc08316e75b892eef66a34e452e6bf67a8ce69
Change-Id: Ie2937724c9b94cd6729f2e9fc2ca53194c3a0374
Change-Id: I4ec7729b2033ff9fbaed830c9778a171acb321f3
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4106 +/- ##
==========================================
- Coverage 57.57% 57.56% -0.02%
==========================================
Files 1746 1745 -1
Lines 86403 86403
==========================================
- Hits 49747 49737 -10
- Misses 36656 36666 +10 ☔ View full report in Codecov by Sentry. |
starboard/contrib/cast/cast_starboard_api/samples/cast_starboard_api_test.cc
Outdated
Show resolved
Hide resolved
starboard/nplb/posix_compliance/posix_directory_get_next_test.cc
Outdated
Show resolved
Hide resolved
starboard/nplb/posix_compliance/posix_file_get_path_info_test.cc
Outdated
Show resolved
Hide resolved
third_party/boringssl/src/config/starboard/openssl/opensslconf.h
Outdated
Show resolved
Hide resolved
third_party/boringssl/src/config/starboard/openssl/opensslconf.h
Outdated
Show resolved
Hide resolved
third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just empty line cleanup nits, and a few empty #ifdef STARBOARDs to get rid of
Change-Id: I1eee7a8f32f37af5443c0e742eabb19e32ce789d
Change-Id: Ia490b44eb35917b1f9ec0fc23a8678f67b68a4ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b/362374622