-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Fix software video decoder fallback #4111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osagie98
approved these changes
Sep 16, 2024
borongc
force-pushed
the
dual_video_fallback
branch
from
September 16, 2024 18:31
e1eb4fc
to
bb0bc17
Compare
If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
force-pushed
the
dual_video_fallback
branch
from
September 16, 2024 18:33
bb0bc17
to
190a83e
Compare
jasonzhangxx
approved these changes
Sep 16, 2024
Note that the 10x player is not enabled on ATV. |
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 7, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 7, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 17, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 21, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 24, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 3103 fixed MIME attribute "framerate" that enforces
a low resolution and low fps playback
to use software video decoder.However, If software video decoder is not available, Cobalt should fallback to hardware video decoder.
b/328537630