[media] Add H5vcc API to set video buffer budget #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The H5vcc API `h5vcc.settings.set("VideoBufferBudget", [value])` will
override the return value of SbMediaGetVideoBufferBudget() in the
DecoderBufferAllocator. When |value| is set to 0, the
DecoderBufferAllocator will revert to using the return value of
SbMediaGetVideoBufferBudget().
b/368717847
osagie98
requested review from
xiaomings,
sideb0ard,
jasonzhangxx,
zhongqiliang and
borongc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h5vcc.settings.set("VideoBufferBudget", [value])overrides the return value ofDecoderBufferAllocator::GetVideoBufferBudget(). The value doesn't change for any playback untilh5vcc.settings.set("VideoBufferBudget", [value])is called again. When the value is set to 0,DecoderBufferAllocator::GetVideoBufferBudget()will revert to using the return value ofSbMediaGetVideoBufferBudget().DecoderBufferAllocatormethodSetVideoBufferBudget(), along with tests.b/368717847